Sitelet https://web.archive.org/web/20211228072511/https://github.com/laurent22/joplin/issues/5482
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile allows CRs in title which is inconsistent behaviour with desktop + can lead to data loss #5482

Open
Daeraxa opened this issue Sep 19, 2021 · 3 comments
Open

Mobile allows CRs in title which is inconsistent behaviour with desktop + can lead to data loss #5482

Daeraxa opened this issue Sep 19, 2021 · 3 comments
Labels
bug desktop good first issue medium

Comments

@Daeraxa
Copy link
Contributor

@Daeraxa Daeraxa commented Sep 19, 2021 •
edited

Environment

Mobile

Joplin 2.3.4
Database v39
Android 11
USING BETA EDITOR

Desktop

Joplin 2.3.5 (prod, win32)
Client ID: a4ed20b9be424a1c8c3e5f3cc355c345
Sync Version: 3
Profile Version: 39
Keychain Supported: Yes
Revision: 819af3c
Windows 10

Steps to reproduce

  1. Create new note and start typing title manually
  2. Press 'return' and continue typing - repeat
  3. Move cursor to note body and type something
  4. Return from note and sync
  5. Access new note on desktop app - Title display is different from mobile and data has been lost
  6. Edit note on desktop + sync
  7. Sync mobile + access note - Now only has single title line, overflow has been moved to body but the "1CR" line has been lost

Mobile seems happy to display the title including the CRLF:

Notes panel:

Viewer:

Desktop puts extra lines into the body of the note (but not all of it - "1CR" is missing):

image

Content of desktop database ("1CR" has been lost):

sqlite> SELECT title,
   ...>        body
   ...>   FROM notes
   ...>  WHERE id = "db7daac4e933415c93aaf1c0939df9b1";
Title|2cr

Line after return

Line after return and 2 spaces


Note body line 1

Content of sync target md file:

Title 1cr 2cr

Line after return

Line after return and 2 spaces

Note body line 1

Describe what you expected to happen

Mobile should not be allowed to put CRs into titles. If it is allowed to then all the data should be visible to the desktop app - current behaviour casuses some data to be lost.
Behaviour of pressing return on mobile keyboard should move cursor to note body

Logfile

syncReport-1632085837890.txt
log.txt
@Daeraxa Daeraxa added the bug label Sep 19, 2021
@Daeraxa
Copy link
Contributor Author

@Daeraxa Daeraxa commented Sep 20, 2021 •
edited

For sake of completion I created a new note with the same content and checked the mobile db which shows the full content within notes.title.

sqlite> select title, body from notes where id="f01f47bdf8a64ac59878f18018d6e73f";
Title2
1cr
2cr

Line after return

Line after return and 2 spaces
|Note body line 1

@Vasuvj24
Copy link

@Vasuvj24 Vasuvj24 commented Oct 9, 2021

is this issue still up?

@laurent22 laurent22 added medium and removed high labels Nov 27, 2021
@Daeraxa
Copy link
Contributor Author

@Daeraxa Daeraxa commented Dec 5, 2021 •
edited

I think I might have been able to solve this myself but I want to check a few things before I submit a PR as it appears the multiline functionality in the title was intentional - but only for Android...

So the "fix" was simply to change this line:

joplin/packages/app-mobile/components/screens/Note.tsx

Line 1182 in 3ddfa0b

multiline={this.enableMultilineTitle_}

to {false}

However it is clearly set up intentionally for platforms that aren't ios?

joplin/packages/app-mobile/components/screens/Note.tsx

Lines 96 to 97 in 3ddfa0b

// iOS doesn't support multiline text fields properly so disable it
this.enableMultilineTitle_ = Platform.OS !== 'ios';

joplin/packages/app-mobile/components/screens/Note.tsx

Line 392 in 3ddfa0b

if (this.enableMultilineTitle_) styles.titleTextInput.height = this.state.titleTextInputHeight;

joplin/packages/app-mobile/components/screens/Note.tsx

Lines 974 to 975 in 3ddfa0b

titleTextInput_contentSizeChange(event: any) {
if (!this.enableMultilineTitle_) return;

So basically, I'm happy to submit a simple PR to change that single line (it does stop you making multiple lines when tested on an android emulator (side note - that was fun to set up........)) but the fact it seems to have been implemented intentionally is what is throwing me. Is anyone aware of why this exists and was implemented as Android only functionality?

If that change is the fix then is there any reason the other linked lines shouldn't be culled entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug desktop good first issue medium
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@laurent22 @Vasuvj24 @Daeraxa