fix single-space env default in docker-compose #5167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The example
docker-compose.ymlin the root dir of this repo uses the env variable default syntax of Docker Compose.However, a space is added before the closing bracket:
This means that the default is not an empty string, but a string with a single white-space character.
This can cause issues in certain cases (
os.environ.get("<var>")returnsTruefor a single-whitespace string instead ofFalsefor an empty string).This PR changes the default variables in the
docker-compose.ymlsuch that they are actually empty.The text was updated successfully, but these errors were encountered: