fs: use async directory processing in cp() #41351
Open
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readdir() functions do not scale well, which is why opendir(), etc. were introduced. This is exacerbated in the current cp() implementation, which calls readdir() recursively. This commit updates cp() to use the opendir() style iteration.
|
Would love to see perf metrics on this if you've got any handy |
lpinca
approved these changes
Dec 29, 2021
bnb
approved these changes
Dec 29, 2021
lpinca
reviewed
Dec 29, 2021
| for await (const dirent of dir) { | ||
| const { name } = dirent; |
There was a problem hiding this comment.
Suggested change
| for await (const dirent of dir) { | |
| const { name } = dirent; | |
| for await (const { name } of dir) { |
Just a nit to save a line. Feel free to ignore.
addaleax
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The
readdir()functions do not scale well, which is whyopendir(), etc. were introduced. This is exacerbated in the currentcp()implementation, which callsreaddir()recursively.This commit updates
cp()to use theopendir()style iteration.The text was updated successfully, but these errors were encountered: