Ruby: Add Module#const_get as a code execution #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module#const_get takes a single string argument and interprets it as the
name of a constant. It then looks up the constant and returns its value.
Object.const_get("Math::PI")
# => 3.141592653589793
By itself, this method is not as dangerous as e.g. eval, but if the
value returned is a class that is then instantiated, this can allow an
attacker to instantiate arbitrary Ruby classes.
As a result, I think it's safe to say that any remote input flowing into
this call is a potential vulnerability. A real-world example of this is
GHSA-52p9-v744-mwjj.
nickrolfe
reviewed
Dec 17, 2021
| */ | ||
| class ModuleConstGetCallCodeExecution extends CodeExecution::Range, DataFlow::CallNode { | ||
| ModuleConstGetCallCodeExecution() { | ||
| this.asExpr().getExpr().(UnknownMethodCall).getMethodName() = "const_get" |
There was a problem hiding this comment.
I'm a little unsure about casting to UnknownMethodCall. Is the idea that all bets are off if the project redefines Module#const_get?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Module#const_gettakes a single string argument and interprets it as thename of a constant. It then looks up the constant and returns its value.
By itself, this method is not as dangerous as e.g.
eval, but if thevalue returned is a class that is then instantiated, this can allow an
attacker to instantiate arbitrary Ruby classes.
As a result, I think it's safe to say that any remote input flowing into
this call is a potential vulnerability. A real-world example of this is
GHSA-52p9-v744-mwjj.
The text was updated successfully, but these errors were encountered: