Sitelet https://web.archive.org/web/20251230164546/https://github.com/github/codeql/pull/7370
Skip to content

C#: Flow summaries for virtual members in abstract classes should also apply to overrides. #7370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelnebel merged 4 commits into from
Dec 13, 2021
Merged

C#: Flow summaries for virtual members in abstract classes should also apply to overrides. #7370

michaelnebel merged 4 commits into from
Dec 13, 2021

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Dec 13, 2021 •
edited
Loading

In this PR we

  • Change the policy on flow summaries; Summaries for virtual members in abstract classes should also apply to overrides.
  • Fix issue with the relevantSummary predicate. Earlier a flow summary could exclude itself.
  • Update testcases.
  • Fix flow summaries for StringReader / TextReader and convert to CSV (this now means that StreamReader will also be covered).

@github-actions github-actions bot added the C# label Dec 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,585,28,5
+    System,"``System.*``, ``System``",3,599,28,5
-    Totals,,3,665,353,5
+    Totals,,3,679,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,585,,4,,23,1,3,490,95
+ System,28,3,599,,4,,23,1,3,504,95

@michaelnebel michaelnebel marked this pull request as ready for review December 13, 2021 13:20
@michaelnebel michaelnebel requested a review from a team as a code owner December 13, 2021 13:20
@michaelnebel michaelnebel merged commit c0b61d7 into github:main Dec 13, 2021
@michaelnebel michaelnebel deleted the csharp-mad-textreader branch December 13, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved