Sitelet https://web.archive.org/web/20211218174418/https://github.com/microsoft/TypeScript/pull/45684
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code coverage command #45684

Merged
merged 1 commit into from Sep 1, 2021
Merged

Remove unused code coverage command #45684

merged 1 commit into from Sep 1, 2021

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Sep 1, 2021

This seems to be unused. The code coverage cron job in DevOps installs nyc and doesn’t use this command.
@andrewbranch andrewbranch requested a review from rbuckton Sep 1, 2021
@andrewbranch andrewbranch merged commit 1a981d1 into microsoft:main Sep 1, 2021
10 checks passed
@andrewbranch andrewbranch deleted the remove-istanbul branch Sep 1, 2021
@weswigham
Copy link
Member

@weswigham weswigham commented Sep 1, 2021

Seeing this made me go check said cron job and realize it hasn't run since we swapped master to main - I've updated the target of the job, so it should start collecting results again~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Uncommitted Bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@andrewbranch @weswigham @typescript-bot