Sitelet https://web.archive.org/web/20260612223336/https://github.com/github/codeql/pull/7289
Skip to content

C#: Convert some of the existing flow summaries to CSV#7289

Merged
michaelnebel merged 4 commits into
github:mainfrom
michaelnebel:csharp-mad-as-csv
Dec 3, 2021
Merged

C#: Convert some of the existing flow summaries to CSV#7289
michaelnebel merged 4 commits into
github:mainfrom
michaelnebel:csharp-mad-as-csv

Conversation

@michaelnebel

@michaelnebel michaelnebel commented Dec 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR we cover the conversion of flow summaries for

  • System.Boolean.
  • System.Uri.

@github-actions github-actions Bot added the C# label Dec 2, 2021
@github-actions

github-actions Bot commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,18,28,5
-    Totals,,3,20,353,5
+    Totals,,3,25,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,18,,4,,23,1,3,18

@github-actions

github-actions Bot commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,25,28,5
-    Totals,,3,20,353,5
+    Totals,,3,32,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,25,,4,,23,1,3,25

@github-actions

github-actions Bot commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,25,28,5
-    Totals,,3,20,353,5
+    Totals,,3,32,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,25,,4,,23,1,3,25

1 similar comment
@github-actions

github-actions Bot commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,25,28,5
-    Totals,,3,20,353,5
+    Totals,,3,32,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,25,,4,,23,1,3,25

@michaelnebel michaelnebel marked this pull request as ready for review December 3, 2021 09:19
@michaelnebel michaelnebel requested a review from a team as a code owner December 3, 2021 09:19
@github-actions

github-actions Bot commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,25,28,5
-    Totals,,3,20,353,5
+    Totals,,3,32,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,25,,4,,23,1,3,25

hvitved
hvitved requested changes Dec 3, 2021
View reviewed changes

@hvitved hvitved left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Comment thread csharp/ql/lib/semmle/code/csharp/frameworks/System.qll Outdated
@github-actions

github-actions Bot commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,25,28,5
-    Totals,,3,20,353,5
+    Totals,,3,32,353,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,25,,4,,23,1,3,25

@michaelnebel michaelnebel requested a review from hvitved December 3, 2021 12:12
@michaelnebel michaelnebel merged commit 4128f56 into github:main Dec 3, 2021
@michaelnebel michaelnebel deleted the csharp-mad-as-csv branch December 3, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved