Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Echo tests unnecessarily run tests in own process #622
Comments
|
Ava only runs tests in their own processes if running in parallel mode. Even still, I don't think it captures the stdio, I think it just goes straight through to the console, which isn't what we want. We could do away with the stdout capturing if we mock |
|
@freitagbr ping. Any progress on this? |
|
When I run the echo tests in concurrent mode, |
|
Yeah, that module seems fine |
|
I did something similar for shx here and here The downside to mocking like this is that we'll need to mock/restore within each test case (I don't think you can do it in setup/teardown). This is lots of boilerplate An alternative approach is to refactor |
|
Fixed in #708 |
To prevent writing to the process' own stdout, the
echotests were written to run each test in its own process, and the stdout of that process was captured. Because ava runs each test in its own process anyway, theechotests no longer need to run in separate processes.