Sitelet https://web.archive.org/web/20211221151814/https://github.com/NativeScript/NativeScript/pull/9560
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: background failing when parsing color #9559 #9560

Merged
merged 1 commit into from Sep 22, 2021
Merged

fix: background failing when parsing color #9559 #9560

merged 1 commit into from Sep 22, 2021

Conversation

@farfromrefug
Copy link
Collaborator

@farfromrefug farfromrefug commented Sep 21, 2021

The parser now returns a Color directly. We need to test for it and not try to create an new instance of Color
@cla-bot cla-bot bot added the cla: yes label Sep 21, 2021
@NathanWalker NathanWalker merged commit 3e21748 into NativeScript:master Sep 22, 2021
2 of 3 checks passed
@rigor789 rigor789 mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@farfromrefug @NathanWalker