Pickle CloudFormationRegion classes for persistence #4580
Conversation
|
Any thoughts on this? It makes it much easier to keep a clean dev environment when using |
|
Hi @dbramwell, thanks for this PR, and apologies for the delay on this one. We're currently in the process of preparing a major PR which will introduce a plugin system and entirely restructures the way that services are loaded and started up: #4648 I have some suggestions for slightly restructuring the changes in this PR - to make them a bit more generic/reusable, but also to ensure they don't collide with existing persistence mechanisms that are plugged in and used in other places. Before we go into a more detailed review, we'd like to wait for the changes in #4648 to get merged (should happen in the next couple of days), then we'll have a clearer picture how this can fit into the new service lifecycle.. Thanks! |
|
Awesome, thanks! Lazy loading sounds like a great idea. No rush |
Attempt to add persistence to the cloudformation implementation by pickling the CloudFormationRegion instances.
I'm unfamiliar with both
pickleand the localstack codebase, so sorry if this is a woefully naive implementation. It does however work well in my simple testing with a cdk project.I'm unsure of the best way to add tests for it, if the implementation seems appropriate then some guidance would be appreciated.
Should hopefully address issue 3191
The text was updated successfully, but these errors were encountered: