Resize "Add choice" poll button based on language #20077
Comments
|
Hello @zulip/server-i18n members, this issue was labeled with the "area: i18n" label, so you may want to check it out! |
|
@zulipbot claim |
|
Welcome to Zulip, @gopik820! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
Turns out we have the same issue with the "Add task" button in TODO lists:
|
|
Also, while we're here, we should check whether we forgot to internationalize the "Task list" string. |
That was also fixed in the PR ,since the width property was common to both buttons. |
Yes it seems that the "Task list" string is not internationalized. |
|
@alya The PR is ready for review. |
|
Cool, could you also fix the "Task list" internationalization? I don't see it in the PR. |
|
Hello @gopik820, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
|
@zulipbot claim |
|
Welcome to Zulip, @LDeolindo! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
Hello @LDeolindo, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
This issue has been partially fixed by PR zulip#20090. I continued from it to ensure that the "Add task" button had been fixed, that the buttons looked good visually, I just added some paddings to ensure that the buttons stayed at the same level as the inputs and the text was spaced out. Tested on my local using manually and visually test. Fixes zulip#20077
|
@zulipbot claim |
At present, the "Add choice" poll button ends up taking two lines in languages where the text on the button is relatively long. E.g. in Russian:
Instead, the button should be sized to fit the full text on one line regardless of language. Note that it should still be sized appropriately in languages where the text is short, without a lot of extra space inside the button.
The text was updated successfully, but these errors were encountered: