Sitelet https://web.archive.org/web/20210821144437/https://github.com/patrikhuber/eos/issues/228
Skip to content

/ eos

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling when a model doesn't have any texture coordinates #228

Open
patrikhuber opened this issue Oct 18, 2018 · 2 comments
Open

Add error handling when a model doesn't have any texture coordinates #228

patrikhuber opened this issue Oct 18, 2018 · 2 comments
Labels
enhancement good first issue

Comments

@patrikhuber
Copy link
Owner

@patrikhuber patrikhuber commented Oct 18, 2018

I've got a report that currently, when a model doesn't have any texture coordinates, eos::render::extract_texture just crashes. We should handle that a bit more gracefully.
@patrikhuber
Copy link
Owner Author

@patrikhuber patrikhuber commented Jun 20, 2019 •
edited

Yes indeed, and another user reported a segfault in #260 when trying to use extract_texture with the BFM, which obviously doesn't have texture coordinates.
@patrikhuber
Copy link
Owner Author

@patrikhuber patrikhuber commented Jun 20, 2019 •
edited

More people trying this and running into this crash/segfaults in #218 and #95.

It is quite clearly documented in the BFM2009 converter script though, and the BFM2017 converter script contains the same note. The part about "Note that eos only supports one uv-coordinate per vertex." is no longer true though, I guess I could remove that.
@patrikhuber patrikhuber mentioned this issue Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@patrikhuber