fix(expect): do not rely on displayName #9523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for displayName was removed in Node 16. Switching to Function.name instead. Relevant V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/2692189
yury-s
approved these changes
Oct 14, 2021
sidharthv96
added a commit
to sidharthv96/playwright
that referenced
this issue
Oct 15, 2021
* upstream/master: (131 commits) fix: separate Selectors instance per Playwright object (microsoft#9529) browser(webkit): fix build on ubuntu 18.04 and mac (microsoft#9540) doc(html): document html reporter (microsoft#9528) chore(create-playwright): nits and cleanups (microsoft#9537) browser(chromium): roll to r931772 (microsoft#9532) feat(html): open show html report when there are failures (microsoft#9526) chore: merge Connection.{close,didDisconnect} (microsoft#9524) docs: clarify default retry behavior (microsoft#9525) fix(expect): do not rely on displayName (microsoft#9523) chore: html report ui fixes (microsoft#9522) chore: start adding html runner e2e tests (microsoft#9518) chore(webpack): fix watch for webpack 5 (microsoft#9516) browser(firefox-beta): fix compilation on win32 (microsoft#9517) devops: fix `//browser_patches/{build.sh,clean.sh}` scripts (microsoft#9515) docs: fix api-testing section id (microsoft#9514) Create `userDataDir` if it does not exist (microsoft#9483) feat(html): unhide html reporter (microsoft#9512) fix: protocol generation in monorepo (microsoft#9513) feat: mark PlaywrightClient's connection as remote (microsoft#9477) browser(webkit): roll to 10/14/21 (microsoft#9510) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Support for displayName was removed in Node 16. Switching to Function.name instead.
Added installation test to cover all node versions we care about.
Relevant V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/2692189
The text was updated successfully, but these errors were encountered: