Sitelet https://web.archive.org/web/20250521080416/https://github.com/angular/angular/pull/19829
Skip to content

feat(forms): expose updateTreeValidity method #19829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(forms): expose updateTreeValidity method #19829

wants to merge 1 commit into from

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Oct 20, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: Closes #6170, closes #19820.

What is the new behavior?

Expose AbstractControl#updateValueAndValidity() to allow user force re-validate a FormGroup.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@trotyl trotyl force-pushed the form-group-update branch 2 times, most recently from 3a3e33f to 5c404d6 Compare October 20, 2017 14:32
@trotyl trotyl force-pushed the form-group-update branch from 5c404d6 to a1ba27c Compare October 21, 2017 02:54
@ngbot
Copy link

ngbot bot commented Jan 16, 2018

Hello? Don't want to hassle you. Sure you're busy. But this PR has some merge conflicts that you probably ought to resolve.
That is... if you want it to be merged someday...

1 similar comment
@ngbot
Copy link

ngbot bot commented Jan 16, 2018

Hello? Don't want to hassle you. Sure you're busy. But this PR has some merge conflicts that you probably ought to resolve.
That is... if you want it to be merged someday...

@kara kara added feature Issue that requests a new feature action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 18, 2018
@Gerros
Copy link

Gerros commented Dec 7, 2018

ping :) would be awesome to have this functionality... working at the moment on a huge form and its really cumbersome to always have to manually iterate over nested forms to update validity or mark a larger part is dirty etc.

@Gerros Gerros mentioned this pull request Dec 7, 2018
Open
@jasonaden jasonaden added this to the needsTriage milestone Jan 29, 2019
@hisham
Copy link

hisham commented Feb 21, 2019

+1. Need this as well.

@ErazerBrecht
Copy link

+1

Would love to remove the 'forEach' / recursvie functions we now have to fix this.

@LeonardoVizzotto
Copy link

I searched in the contributing guidelines but haven't found anything about opening a PR for a feature that already has a PR associated with.

Since the last update on this one is from 2017, I was thinking about opening a new PR.

@AndrewKushnir AndrewKushnir added the forms: Controls API Issues related to AbstractControl, FormControl, FormGroup, FormArray. label May 8, 2020
@pullapprove pullapprove bot requested a review from AndrewKushnir May 8, 2020 23:25
@mshehadeh
Copy link

What's the status with this? Did someone open a new PR?

@SamKamalesan
Copy link

This will be a nice to have functionality, which reduce tons of repeated code in app. Can you please release this functionality as soon as possible ?

@phantomsom
Copy link

+1

@jessicajaniuk
Copy link
Contributor

We're going to close this PR since it's out of date, but the issues both remain open and are still being discussed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

Assignees
No one assigned
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: forms cla: yes feature Issue that requests a new feature forms: Controls API Issues related to AbstractControl, FormControl, FormGroup, FormArray.
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Can't explicitly validate ControlGroup Provide a validation function at ngForm