Ignore .env.production in Node.js
#3651
Merged
Conversation
kachick
reviewed
Feb 15, 2021
bl-ue
approved these changes
Feb 27, 2021
Really, really good idea
I just opened 3 issues on repos where I found similar things.
BTW it's already 32,996 .env.productions now haha
MattIPv4
approved these changes
May 25, 2021
Lgtm, seems sane
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reasons for making this change:
See https://github.com/search?q=filename%3A.env.production
Then I saw some configurations they contain actual DB passwords, AWS secrets... (So I sent 2 PRs and 1 repository is deleted immediately...)
.env.productionor not.I🙏 this change reduces sad accidents.
FYI:
Rails.gitignorealready has same config from another issue #3065The text was updated successfully, but these errors were encountered: