Merged
Conversation
This is a first pass to fix obvious holes and outdated information, but we should rethink these docs completely.
shati-patel
reviewed
Sep 8, 2021
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
You're right that this page probably needs a full rework, but good idea to patch up some obvious inconsistencies 😅
I don't know too much about the new QL pack structure, but I've left a few small comments (to hopefully get the PR checks passing at least!)
aeisenberg
commented
Sep 8, 2021
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Contributor
Author
|
Thank you for your detailed review! |
shati-patel
previously approved these changes
Sep 8, 2021
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
One more tiny thing, then LGTM! 📦🚢
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass to fix obvious holes and outdated information, but
we should rethink these docs completely.