Sitelet https://web.archive.org/web/20211221151745/https://github.com/NativeScript/NativeScript/pull/9497
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte changes from halfnelson #9497

Merged
merged 5 commits into from Aug 11, 2021
Merged

svelte changes from halfnelson #9497

merged 5 commits into from Aug 11, 2021

Conversation

@farfromrefug
Copy link
Collaborator

@farfromrefug farfromrefug commented Aug 4, 2021

I think this should do it from what he did
@cla-bot
Copy link

@cla-bot cla-bot bot commented Aug 4, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @halfnelson.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@farfromrefug
Copy link
Collaborator Author

@farfromrefug farfromrefug commented Aug 4, 2021

@rigor789 why is the bot asking for @halfnelson cla ...

@cla-bot
Copy link

@cla-bot cla-bot bot commented Aug 4, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @halfnelson.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789 rigor789 merged commit 59d9271 into NativeScript:master Aug 11, 2021
1 of 3 checks passed
@farfromrefug farfromrefug deleted the pullrequests/halfnelson/feat/webpack5 branch Aug 11, 2021
rigor789 added a commit that referenced this issue Sep 7, 2021
@farfromrefug @halfnelson @rigor789
feat(webpack): improved svelte HMR (#9497)
b3ca5de 
* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
rigor789 added a commit that referenced this issue Sep 7, 2021
@farfromrefug @halfnelson @rigor789
feat: Frame replacePage by entry (#9460)
4a5bec1 
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <martin.guillon@akylas.fr>
Co-authored-by: halfnelson <dpershouse@gmail.com>
NathanWalker added a commit that referenced this issue Sep 8, 2021
@farfromrefug @halfnelson
@rigor789 @NathanWalker
feat: Frame replacePage by entry (#9460)
ffab4c3 
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <martin.guillon@akylas.fr>
Co-authored-by: halfnelson <dpershouse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@farfromrefug @rigor789 @halfnelson