Sitelet https://web.archive.org/web/20210815103720/https://github.com/trinodb/trino/issues/8185
Skip to content

/ trino

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trino/Presto UI does not respect show limit when query state filter is changed #8185

Open
cpsnowden opened this issue Jun 3, 2021 · 2 comments · May be fixed by #8190
Open

Trino/Presto UI does not respect show limit when query state filter is changed #8185

cpsnowden opened this issue Jun 3, 2021 · 2 comments · May be fixed by #8190
Labels
bug good first issue ui

Comments

@cpsnowden
Copy link

@cpsnowden cpsnowden commented Jun 3, 2021 •
edited

When you change a query state filter e.g. showing 'Finished' queries or 'User Error' queries, the Show Limit is not respected immediately resulting in all queries being rendered. If a re-order interval is set then Show Limit is applied on the next query refresh. If there are a large number of queries in the history this can result in the browser crashing on the first render.

The following two calls to sortAndLimitQueries looks like they are missing a last parameter of this.state.maxQueries resulting in no limit being applied

https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/resources/webapp/src/components/QueryList.jsx#L512
https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/resources/webapp/src/components/QueryList.jsx#L544
@hashhar hashhar added the ui label Jun 3, 2021
@hashhar
Copy link
Member

@hashhar hashhar commented Jun 3, 2021

Thanks for reporting this @cpsnowden. Would you like to submit a pull-request yourself - we can guide you through the process.
@cpsnowden
Copy link
Author

@cpsnowden cpsnowden commented Jun 3, 2021

Yep - can contribute a PR for this
@cpsnowden cpsnowden linked a pull request that will close this issue Jun 3, 2021
Open
@findepi findepi added the bug label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue ui
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Apply limit in WebUI when query state or error type filters update
3 participants
@findepi @hashhar @cpsnowden