Sitelet https://web.archive.org/web/20211121102520/https://github.com/ionic-team/stencil/issues/2169
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preamble config option doesn't work #2169

Closed
danschultz opened this issue Jan 28, 2020 · 6 comments
Closed

Preamble config option doesn't work #2169

danschultz opened this issue Jan 28, 2020 · 6 comments
Labels
Bug: Needs Validation Good First Issue Resolution: Shipped

Comments

@danschultz
Copy link

@danschultz danschultz commented Jan 28, 2020

Stencil version:

 @stencil/core@1.8.1

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
Specifying a preamble value in my Stencil config doesn't show up in my JS bundle.

Expected behavior:
The main JS bundle in ./dist should contain the preamble value set in Stencil's config.

Steps to reproduce:
Set the preamble in your stencil.config.ts file. Something like:

export const config: Config = {
  preamble: "Test preamble"
}

Run npm run build.

Related code:

// insert any relevant code here

Other information:
Issue was previously reported with in #1723 but was closed due to inactivity.

https://stenciljs.com/docs/config#preamble
@ionitron-bot ionitron-bot bot added the triage label Jan 28, 2020
@simonhaenisch
Copy link
Contributor

@simonhaenisch simonhaenisch commented Mar 25, 2020

stencil/src/utils/util.ts

Line 91 in d04fb90

export const generatePreamble = (config: d.Config, opts: { prefix?: string; suffix?: string; defaultBanner?: boolean } = {}) => {

is still not used.

Loading

@donskov
Copy link

@donskov donskov commented Aug 26, 2020

Hello. Any progress?

Loading

@dutscher
Copy link
Contributor

@dutscher dutscher commented Dec 7, 2020 •
edited
Loading

why this is still ignored?
this is also reported here last year: #1723

cheers

inspector gadget:

@adamdbradley committed on 3 Jun 2019: ionic-team/stencil-site@1263d1e#diff-689c19470ae2ed5ac0b4ba2bb534871dd960e99ae1638ca7da6bab934a5dd022R106

Loading

@claviska claviska mentioned this issue Jan 7, 2021
Closed
@cgpro
Copy link

@cgpro cgpro commented Jun 24, 2021

It would be great if the fix will be merged!

Loading

@jcfranco jcfranco mentioned this issue Jul 14, 2021
Closed
@splitinfinities splitinfinities mentioned this issue Aug 10, 2021
Closed
@rwaskiewicz rwaskiewicz mentioned this issue Sep 29, 2021
Merged
14 tasks
@rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Oct 6, 2021

This was fixed in #3085, and should be available in the next release of Stencil

Loading

@rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Oct 21, 2021

I'm going to close this issue, as v2.9.0 of Stencil resolves this issue. Please feel free to open a new issue if you feel the current functionality doesn't meet your expectations!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Needs Validation Good First Issue Resolution: Shipped
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix(): output preamble in generated files
7 participants
@dutscher @danschultz @splitinfinities @cgpro @rwaskiewicz @simonhaenisch @donskov