Custom Route Matchers example fails #1667

gscragg · 2020-12-09T01:39:55Z

I am trying to write my own custom route matcher and using the example in the readme, I receive the following error:
AllButPattern can't be coerced into Mustermann::Pattern (TypeError)

Here is my example code:

require 'sinatra'

get '/index' do
  'Hello world!'
end

class AllButPattern
  Match = Struct.new(:captures)

  def initialize(except)
    @except   = except
    @captures = Match.new([])
  end

  def match(str)
    @captures unless @except === str
  end
end

def all_but(pattern)
  AllButPattern.new(pattern)
end

get all_but("/index") do
  "yep yep yep"
end

It would seem as if the API for these matchers has changed with the introduction of Mustermann (4 odd years ago).

The text was updated successfully, but these errors were encountered:

gscragg · 2020-12-13T19:52:29Z

I figured out a fix for my problem, but I am not sure its a good one:

require 'sinatra'

class AllButPattern

  def initialize(except)
    @except = except
  end

  def to_pattern(**options)
    return self
  end

  def params(route)
    return {} unless @except === route
  end
end

def all_but(pattern)
  AllButPattern.new(pattern)
end

get all_but("/index") do
  "yep yep yep"
end

kgrz added the good first issue label Dec 10, 2020

sinatra / sinatra

Custom Route Matchers example fails #1667

Custom Route Matchers example fails #1667

gscragg commented Dec 9, 2020

gscragg commented Dec 13, 2020 •

edited

sinatra / sinatra

Custom Route Matchers example fails #1667

Custom Route Matchers example fails #1667

Comments

gscragg commented Dec 9, 2020

gscragg commented Dec 13, 2020 • edited

gscragg commented Dec 13, 2020 •

edited