Sitelet https://web.archive.org/web/20211009072045/https://github.com/vapor/vapor/issues/2574
Skip to content

/ vapor Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing quote from value of filename in multipart/form-data #2574

Open
octarrow opened this issue Feb 28, 2021 · 2 comments
Open

Missing quote from value of filename in multipart/form-data #2574

octarrow opened this issue Feb 28, 2021 · 2 comments
Labels
good first issue

Comments

@octarrow
Copy link

@octarrow octarrow commented Feb 28, 2021

Same issue as vapor/multipart-kit#22 (comment)

Looks like a easy fix in the following line, just make it always quote the parameter

vapor/Sources/Vapor/HTTP/Headers/HTTPHeaders+Directive.swift

Line 180 in 07478e1

if self.shouldQuote(parameter) {

@eoola
Copy link

@eoola eoola commented Jul 18, 2021

I would like to tackle this. If that's alright

@0xTim
Copy link
Member

@0xTim 0xTim commented Jul 18, 2021

@eoola That would be great!

octarrow pushed a commit to octarrow/vapor that referenced this issue Jul 22, 2021
@oadoad
a temporary fix of multipart filename quote (vapor#2574);
cc9b9db 
make HTTPClient delegating method public accessible;
@akaffenberger akaffenberger mentioned this issue Oct 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@octarrow @0xTim @eoola