Sitelet https://web.archive.org/web/20210707034019/https://github.com/ant-design/ant-design/issues/28082
Skip to content

/ ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer property of Transfer component can be received value as an array of node #28082

Open
1 task done
tuansong opened this issue Nov 30, 2020 · 3 comments
Open
1 task done

Footer property of Transfer component can be received value as an array of node #28082

tuansong opened this issue Nov 30, 2020 · 3 comments
Labels
Inactive good first issue help wanted

Comments

@tuansong
Copy link
Task lists! Give feedback

@tuansong tuansong commented Nov 30, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

I am making a feature for changing the order of each item in targetKeys before saving the data, and the UI is two buttons on the footer. But seems like the left list of transfer component does not need those button for any reasons

What does the proposed API look like?

Property: footer
Description: A set of footers that are sorted from left to right
Type: ReactNode[]

Or making a separate API for leftFooter & rightFooter

Regards,
Song
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Dec 1, 2020

Hello @tuansong. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @tuansong, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！

giphy
@Eating-Eating
Copy link
Contributor

@Eating-Eating Eating-Eating commented Feb 8, 2021

let me try,i wonder i could making a separate API for leftFooter & rightFooter.
@Eating-Eating Eating-Eating mentioned this issue Feb 8, 2021
Closed
5 of 19 tasks
@xlei1123
Copy link

@xlei1123 xlei1123 commented Mar 11, 2021

OK, I'll send a PR for it as soon as possible.
@afc163 afc163 mentioned this issue Jun 22, 2021
Closed
1 task
@xrkffgg xrkffgg mentioned this issue Jun 23, 2021
Merged
5 of 19 tasks
afc163 pushed a commit that referenced this issue Jun 30, 2021
@xrkffgg
feat: Transfer support customize footer (#31108)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5d8b46c 
close #28082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Inactive good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@afc163 @xlei1123 @tuansong @ant-design-bot @Eating-Eating