Sitelet https://web.archive.org/web/20210810003204/https://github.com/angular/angular-cli/pull/21538
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): add noImplicitOverride and noPropertyAccessFromIndexSignature to workspace tsconfig #21538

Merged
merged 1 commit into from Aug 9, 2021

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 9, 2021

With this change, when the workspace is created in strict mode (the default) we add the following additional tsconfig options;

Closes #21279

…cessFromIndexSignature` to workspace tsconfig

With this change, when the workspace is created in strict mode (the default) we add the following  additional tsconfig options;
- [noImplicitOverride](https://www.typescriptlang.org/tsconfig#noImplicitOverride)
- [noPropertyAccessFromIndexSignature](https://www.typescriptlang.org/tsconfig#noPropertyAccessFromIndexSignature)

Closes #21279
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@alan-agius4 alan-agius4 requested a review from clydin Aug 9, 2021
@clydin
clydin approved these changes Aug 9, 2021
@alan-agius4 alan-agius4 merged commit 3ba13f4 into angular:master Aug 9, 2021
12 checks passed
12 checks passed
@in-solidarity
Inclusive Language Check completed with success
Details
@ngbot
ci/angular: merge status All checks passed!
@ngbot
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-win Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
@google-cla
cla/google All necessary CLAs are signed
@alan-agius4 alan-agius4 deleted the alan-agius4:tsconfig-options branch Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants