Sitelet https://web.archive.org/web/20210805000529/https://github.com/PowerShell/PowerShellGet/pull/363
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Find-PSResource cmdlet #363

Merged
merged 61 commits into from Jun 21, 2021

Conversation

@anamnavi
Copy link
Member

@anamnavi anamnavi commented Apr 24, 2021 •

This PR includes refactoring for the Find-PSResource cmdlet. This cmdlet searches for requested packages.

Note:

  • At the moment this PR just includes core Find-PSResource functionality (ResourceNameParameterSet).
  • DscResourceNameParameterSet, CommandNameParameterSet, TagParameterSet, TypeParameterSet soon to be completed.
  • The code is refactored into a FindHelper.cs class so that Publish-PSResource may also utilize it.
  • Resolves issues #281 #284 #259 #247 #201 #109 #173 #212 #264

PR Summary

Summary for this PR:

  • refactored Find-PSResource.cs
  • added tests with production module in this PR
  • updated help and design docs for this cmdlet in this PR.
  • add formatting for PSResourceInfo objects

PR Context

PR Checklist

@anamnavi anamnavi requested review from PaulHigin and alerickson Apr 24, 2021
Copy link
Collaborator

@PaulHigin PaulHigin left a comment

LGTM

@anamnavi anamnavi merged commit 07ac5ff into PowerShell:development Jun 21, 2021
8 of 9 checks passed
8 of 9 checks passed
@github-actions
Analyze (csharp)
Details
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
@azure-pipelines
PowerShell.PowerShellGet Build #PowerShell.PowerShellGet-2106.21007 succeeded
Details
@azure-pipelines
PowerShell.PowerShellGet (Build PowerShellGet Module Package Build Package) Build PowerShellGet Module Package Build Package succeeded
Details
@azure-pipelines
PowerShell.PowerShellGet (Compliance ComplianceJob) Compliance ComplianceJob succeeded
Details
@azure-pipelines
PowerShell.PowerShellGet (Test Package PowerShell Core on Windows) Test Package PowerShell Core on Windows succeeded
Details
@azure-pipelines
PowerShell.PowerShellGet (Test Package Windows PowerShell on Windows) Test Package Windows PowerShell on Windows succeeded
Details
@microsoft-cla
license/cla All CLA requirements met.
Details
@anamnavi anamnavi changed the title WIP: Refactor Find-PSResource cmdlet Refactor Find-PSResource cmdlet Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants