Do not run general and command subshard during web_tool_tests when subshard env is missing #87385
+2
−2
Conversation
|
Framework tests still run the expected subshards: https://ci.chromium.org/p/flutter/builders/try/Windows%20tool_tests_general/4571? https://ci.chromium.org/p/flutter/builders/try/Windows%20tool_tests_commands/4559? https://ci.chromium.org/p/flutter/builders/try/Windows%20web_tool_tests/4456? |
|
LGTM |
0abf02f
into
flutter:master
100 checks passed
100 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Dart HHH was not passing in the expected
SUBSHARDenvironment variables. This caused itstool_teststo runweb.shardin addition togeneralandcommands. And for itsweb_tool_teststo run all thetool_testsshards again. So all the tools tests were running for both HHH shards.Instead, when subshard isn't specified, only run
generalandcommandssubshard fortool_tests, and only run thewebsubshard forweb_tool_tests. This shouldn't impact the flutter/flutter tests.Fixes dart-lang/sdk#46768.