Sitelet https://web.archive.org/web/20210725165639/https://github.com/python/cpython/pull/27217
Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43950: distinguish errors happening on character offset decoding #27217

Merged
merged 1 commit into from Jul 20, 2021
Merged

bpo-43950: distinguish errors happening on character offset decoding #27217

merged 1 commit into from Jul 20, 2021

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented Jul 17, 2021 •
edited by bedevere-bot

_PyPegen_byte_offset_to_character_offset now returns -1 on error since we need to distinguish 0-width lines from errors. Also the error checks are added to the call sites.

https://bugs.python.org/issue43950
@isidentical
bpo-43950: distinguish errors happening on character offset decoding
649f51d
@isidentical isidentical requested review from ammaraskar and pablogsal Jul 17, 2021
@isidentical isidentical requested a review from lysnikolaou as a code owner Jul 17, 2021
@pablogsal
pablogsal approved these changes Jul 20, 2021
View changes
@pablogsal pablogsal merged commit fbc349f into python:main Jul 20, 2021
11 of 12 checks passed
11 of 12 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210717.31 failed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 43950 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@isidentical
Copy link
Member Author

@isidentical isidentical commented Jul 20, 2021

Thanks @pablogsal!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@ammaraskar ammaraskar

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@isidentical @pablogsal @the-knights-who-say-ni @bedevere-bot