Sitelet https://web.archive.org/web/20220203022317/https://github.com/python/cpython/pull/27259
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44353: Add test to cover __or__ of two typing.NewType #27259

Merged
merged 1 commit into from Jul 20, 2021
Merged

bpo-44353: Add test to cover __or__ of two typing.NewType #27259

merged 1 commit into from Jul 20, 2021

Conversation

@uriyyo
Copy link
Member

@uriyyo uriyyo commented Jul 20, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44353
@uriyyo uriyyo requested a review from gvanrossum as a code owner Jul 20, 2021
@uriyyo
Copy link
Member Author

@uriyyo uriyyo commented Jul 20, 2021

@Fidget-Spinner Could you please review this PR and add skip-news label?

Fidget-Spinner
Fidget-Spinner approved these changes Jul 20, 2021
View changes
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner left a comment •
edited by ambv

LGTM.

PS: To whoever merges this. This needs GH-27258 to be merged first before backporting.

@ambv ambv merged commit 4868b94 into python:main Jul 20, 2021
12 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 20, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 20, 2021

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 20, 2021

Sorry, @uriyyo and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4868b94c6089d457673b1ba5b5b64c2f38c435af 3.10

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented Jul 20, 2021

Cherry picker isn't needed, just needs GH-27250. I will re-add the label when that lands.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 20, 2021

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 20, 2021

Sorry @uriyyo and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4868b94c6089d457673b1ba5b5b64c2f38c435af 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 20, 2021

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 20, 2021

GH-27261 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 20, 2021
@uriyyo @miss-islington
bpo-44353: Add test to cover __or__ of two NewType (pythonGH-27259)
d158d6a 
(cherry picked from commit 4868b94)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
ambv pushed a commit that referenced this issue Jul 20, 2021
@uriyyo @miss-islington
bpo-44353: Add test to cover __or__ of two NewType (GH-27259) (#27261)
9ae5ba7 
(cherry picked from commit 4868b94)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@uriyyo @JuniorJPDJ
bpo-44353: Add test to cover __or__ of two NewType (python#27259)
c2bd6ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

@gvanrossum gvanrossum

Assignees

@ambv ambv

Labels
CLA signed skip news type-tests
Projects
None yet
Milestone
No milestone
6 participants
@uriyyo @bedevere-bot @miss-islington @Fidget-Spinner @ambv @the-knights-who-say-ni