C#: Remove type args/params from generic type names in extractor#6268
Conversation
c9a5a9f to
178598b
Compare
hvitved
left a comment
There was a problem hiding this comment.
We should also generate a DB upgrade script for adjusting the third column of the types relation.
|
@hvitved I adjusted this PR based on your feedback. This is my first upgrade script, so please double check. I've ran the DB upgrade on a dummy DB, which was extracted with the previous version of the extractor, and I could query the generic types afterwards. |
hvitved
left a comment
There was a problem hiding this comment.
The upgrade script looks correct to me. I have approved the PR, but please do not merge before the rc/3.2 release branch has been created, as there is no need for this change to go into the release.
4f63653 to
6405b89
Compare
|
Started a new diff job: https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1242/ |
|
new diff job to check useless upcast performance: |
|
diff job to check |
|
@hvitved The diff jobs show better performance now. The first one shows some perf change in The failing test seems to be unrelated. |
This PR changes the extractor to remove
<,,,>and<T1,T2,T3>-like suffixes from unbound and constructed generic types. With this change, the type names stored in the DB are always "undecorated" for generic types. Additionally, the QL library is adjusted to handle the name change (in unbound/constructed generic types, nullable types, and tuples).