Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support for Subversion #1142
Support for Subversion #1142
Conversation
| :None: clean (status is empty) | ||
| With file argument: returns status of this file: The status codes are | ||
| those returned by bzr status -S |
ZyX-I
Nov 6, 2014
Contributor
bzr status?
bzr status?
| } | ||
| s = self.client.status(join(directory, path)) | ||
| if s: | ||
| s = s .pop() |
ZyX-I
Nov 6, 2014
Contributor
Invalid space here. Please use the lint checker as described in documentation (also duplicated in /.local.vimrc for syntastic) on all files.
Invalid space here. Please use the lint checker as described in documentation (also duplicated in /.local.vimrc for syntastic) on all files.
|
|
||
| def revision(self, directory, config_file): | ||
| info = self.client.info(directory) | ||
| return u"/{path}:r{revision}".format( |
ZyX-I
Nov 6, 2014
Contributor
You should not use u"": first, almost everywhere single quotes are used. Second, there is from __future__ import unicode_literals at the top.
You should not use u"": first, almost everywhere single quotes are used. Second, there is from __future__ import unicode_literals at the top.
| @@ -217,6 +217,7 @@ def tree_status(repo, pl): | |||
| ('git', '.git', os.path.exists), | |||
| ('mercurial', '.hg', os.path.isdir), | |||
| ('bzr', '.bzr', os.path.isdir), | |||
| ('svn', '.svn', os.path.isdir), | |||
ZyX-I
Nov 6, 2014
Contributor
Should be using full name here: 'subversion', not 'svn'. With this change all module names will be the same as package names in almost every linux system (for some reason there are git, mercurial, subversion and bzr packages even though full name is bazaar).
Should be using full name here: 'subversion', not 'svn'. With this change all module names will be the same as package names in almost every linux system (for some reason there are git, mercurial, subversion and bzr packages even though full name is bazaar).
|
Also missing documentation update: it should mention that |
|
In any case, good job! |
|
I addressed your issues and rebased my commits to be more concise in their changes. |
|
And forgot a thing: Maybe also |
befd150
to
c5afa80
|
I'm not aware of a way to install |
|
Then I guess it will be better to distribute binaries in I can say I know binaries compiled on rather modern Gentoo (mostly stable versions) for itself worked well in neovim project dependencies (until they set up the bot that does compilation in travis). But I do not think that compiling pysvn in install step will raise build time enough. Thus it looks like putting |
|
After looking further into the installation process of PySVN, I'd say, that I'd not recommend installing it directly from source (shiver). Feel free to close this PR as I think that me basing it on PySVN was the wrong decision in the first place. |
|
@fladi Have you actually tried doing this in travis? I saw reports that pip install works for pysvn (as well as complaints about installation process). |
|
Installing it with pip only installs the wrapper for the CXX extension, not the C++ library itself ... thats done by a (64kb) setup_configure.py that has to be called with paths to the various library header files. I tried doing it on travis but gave up after several failed attempts. |
|
Judging from this person's travis config (and green build), apt-get'ing pysvn can work: https://github.com/yadt/yadt-config-rpm-maker/blob/master/.travis.yml |
|
@ccope This person is using only one Python version. I think it happens to be the same as system version. |
|
@fladi If you know how to build pysvn you can post a script here so that it can be used with https://github.com/powerline/bot-ci (do not run PR there (more precise: if you run the PR do not expect it to build): uploading build results requires deployment key, deployment key requires encryption and encrypted environment variables are not available in PRs thus PRs builds are disabled there because they should fail otherwise). |
This adds a new VCS module called
svn.pythat uses PySVN to gather information if the current working directory is part of a Subversion repository.As there is no clear definition of a branch in Subversion, this module uses the difference between the actual (remote) repository root URL and the URL of the checked out copy as the branch name. If the Subversion repository follows the usual conventions, this would lead to names like
/trunk,/branch/feature/fooor/tag/1.0.1. The currently checked our revision number is displayed after the branch name (as in/trunk:r1234). If the local copy was checked out from the remote repository root URL, the branch name will simply be/.