Sitelet https://web.archive.org/web/20201203092821/https://github.com/AdAway/AdAway/issues/1450
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve font size for tcpdum log entries #1450

Open
ale82to opened this issue Oct 13, 2019 · 5 comments
Open

Improve font size for tcpdum log entries #1450

ale82to opened this issue Oct 13, 2019 · 5 comments

Comments

@ale82to
Copy link

@ale82to ale82to commented Oct 13, 2019

I really wonder why AdAway has zero respect for vision impaired people!
font size for tcpdump log entries are too small!!!
very disgusted

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Oct 21, 2019

Hello @ale82to,

You have to understand this app is not designed to offense vision impaired people. It is just build by a guy the weekend on its free time.
Is he a user experience or design professional? Or at least trained to? No.
Is there a big company with lot of resources behind the app? Again no.

More important, can he count on affected users to help him by gently explaining the issue and proposing some fixes? Apparently no.

I know there is some issues. Especially with contrast and color bind people #750 but as you can see, I don't get a lot of feedback on my efforts either.
AdAway is an Open Source project and will always be happy to welcome new users. If you feel offended, you are free to improve it and help others in your case. Otherwise, just uninstall it it is a burden to you.

Regards

@Vankog
Copy link
Member

@Vankog Vankog commented Oct 21, 2019

I think this might be a good topic for anyone who wants to get started contributing to AdAway.

@Vankog Vankog changed the title font size for tcpdum log entry to small Improve font size for tcpdum log entries Oct 21, 2019
@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Oct 22, 2019

Totally agree!
I guess following the Google material guideline should provide the right size font to use.

More over, I think the overall list item layout should be improve to have only one icon, showing the current status. Clicking on it bring a popup to select the new state.

Displaying 3 icons is useless because not all states could be enable at the same time.
And as we need more space to display text, it could be a good evolution.

@Vankog Are you sure about help wanted label? No user is requesting for help here. More like an enhancement of the app.

@Vankog
Copy link
Member

@Vankog Vankog commented Oct 22, 2019

"Help wanted" is a github standard tag. It denotes topics open for potential contributors.
Complementarity to that, "good first issue" is intended for inexperienced users looking to get involved in open source.

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Oct 23, 2019

Damned, you're right! I always miss understand this label.. Thanks for the clarification 👍

@AdAway AdAway deleted a comment from tcbnt Aug 23, 2020
@AdAway AdAway deleted a comment from tcbnt Aug 23, 2020
@AdAway AdAway deleted a comment from tcbnt Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.