Sitelet https://web.archive.org/web/20210724232207/https://github.com/microsoft/vscode/issues/122427
Skip to content

/ vscode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tooltip shown when hovering over a terminal status #122427

Open
egamma opened this issue Apr 27, 2021 · 7 comments · May be fixed by #125895
Open

No tooltip shown when hovering over a terminal status #122427

egamma opened this issue Apr 27, 2021 · 7 comments · May be fixed by #125895
Assignees
@jrieken
Labels
bug file-decorations good first issue help wanted

Comments

@egamma
Copy link
Member

@egamma egamma commented Apr 27, 2021 •
edited

Testing #122241

There is no tooltip over the terminal status e.g. , the other items have a tooltip. The tooltip could say 'Relaunch Needed'.

There also is no tooltip on the bell icon.

image
@meganrogge meganrogge added this to the April 2021 milestone Apr 27, 2021
@Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 27, 2021

This also happens in SCM and explorer decorations, looks like it happens because the hover listener is on .monaco-icon-label-container and not .monaco-icon-label
image

Changing the container to its parent will end up breaking the actions:

image

vscode/src/vs/base/browser/ui/iconLabel/iconLabel.ts

Line 155 in 61364b0

this.setupHover(this.labelContainer, options?.title);

@Tyriar Tyriar removed this from the April 2021 milestone Apr 27, 2021
@ghost

This comment was marked as off-topic.

Sign in to view
@khoaleanhvn
Copy link

@khoaleanhvn khoaleanhvn commented May 5, 2021

Anybody's working on this? If not, I will try.
@ghost

This comment was marked as spam.

Sign in to view
@Tyriar Tyriar mentioned this issue May 20, 2021
Closed
@Ashray123
Copy link
Contributor

@Ashray123 Ashray123 commented May 22, 2021

Hello @jrieken, I would love to work on this issue if no one is working on it, could you provide a guide on what is to be done.
@Manish-Giri
Copy link

@Manish-Giri Manish-Giri commented May 22, 2021

I would be happy to take this up. Looks like @Ashray123 has already requested to take up #124419, so this one should be available.
timfenney pushed a commit to timfenney/vscode that referenced this issue Jun 10, 2021
Timothy Fenney
Fix terminal icon hover.
e358e74 
Fixes issue microsoft#122427.
@timfenney timfenney linked a pull request that will close this issue Jun 10, 2021
Open
@timfenney
Copy link

@timfenney timfenney commented Jun 10, 2021

This also happens in SCM and explorer decorations, looks like it happens because the hover listener is on .monaco-icon-label-container and not .monaco-icon-label
image

Changing the container to its parent will end up breaking the actions:

image

vscode/src/vs/base/browser/ui/iconLabel/iconLabel.ts

Line 155 in 61364b0

this.setupHover(this.labelContainer, options?.title);

Hey @Tyriar, I created the PR above, and didn't notice any broken actions on my branch. Do you mean that the other buttons won't work, e.g. for a Terminal session the 🗑️ ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
bug file-decorations good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix terminal icon hover.
8 participants
@egamma @timfenney @jrieken @Tyriar @Manish-Giri @meganrogge @Ashray123 @khoaleanhvn