Sitelet https://web.archive.org/web/20210722051114/https://github.com/flutter/flutter/pull/86837
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter] remove elevation checker #86837

Merged

Conversation

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 22, 2021 •

The flutter runner no longer uses the elevation to determine how to position Flutter layers. This makes Z fighting impossible, and removes the need for a dedicated debug functionality. FYI @arbreng

@jonahwilliams jonahwilliams marked this pull request as ready for review Jul 22, 2021
@jonahwilliams jonahwilliams requested a review from dnfield Jul 22, 2021
Copy link
Member

@dnfield dnfield left a comment

I thought someone might have asked me about this in the last few months but I can't remember who and we can always put it back if really needed.

Lgtm

@fluttergithubbot fluttergithubbot merged commit 7f26dbe into flutter:master Jul 22, 2021
95 checks passed
95 checks passed
@flutter-dashboard
Linux analyze
Details
@flutter-dashboard
Linux build_aar_module_test
Details
@flutter-dashboard
Linux build_tests_1_2
Details
@flutter-dashboard
Linux build_tests_2_2
Details
@flutter-dashboard
Linux customer_testing
Details
@flutter-dashboard
Linux docs
Details
@flutter-dashboard
Linux firebase_abstract_method_smoke_test
Details
@flutter-dashboard
Linux firebase_android_embedding_v2_smoke_test
Details
@flutter-dashboard
Linux firebase_release_smoke_test
Details
@flutter-dashboard
Linux flutter_plugins
Details
@flutter-dashboard
Linux framework_tests_libraries
Details
@flutter-dashboard
Linux framework_tests_misc
Details
@flutter-dashboard
Linux framework_tests_widgets
Details
@flutter-dashboard
Linux fuchsia_precache
Details
@flutter-dashboard
Linux module_custom_host_app_name_test
Details
@flutter-dashboard
Linux module_host_with_custom_build_test
Details
@flutter-dashboard
Linux module_test
Details
@flutter-dashboard
Linux plugin_test
Details
@flutter-dashboard
Linux skp_generator
Details
@flutter-dashboard
Linux tool_integration_tests_1_4
Details
@flutter-dashboard
Linux tool_integration_tests_2_4
Details
@flutter-dashboard
Linux tool_integration_tests_3_4
Details
@flutter-dashboard
Linux tool_integration_tests_4_4
Details
@flutter-dashboard
Linux tool_tests_commands
Details
@flutter-dashboard
Linux tool_tests_general
Details
@flutter-dashboard
Linux web_long_running_tests_1_5
Details
@flutter-dashboard
Linux web_long_running_tests_2_5
Details
@flutter-dashboard
Linux web_long_running_tests_3_5
Details
@flutter-dashboard
Linux web_long_running_tests_4_5
Details
@flutter-dashboard
Linux web_long_running_tests_5_5
Details
@flutter-dashboard
Linux web_tests_0
Details
@flutter-dashboard
Linux web_tests_1
Details
@flutter-dashboard
Linux web_tests_2
Details
@flutter-dashboard
Linux web_tests_3
Details
@flutter-dashboard
Linux web_tests_4
Details
@flutter-dashboard
Linux web_tests_5
Details
@flutter-dashboard
Linux web_tests_6
Details
@flutter-dashboard
Linux web_tests_7_last
Details
@flutter-dashboard
Linux web_tool_tests
Details
@flutter-dashboard
Mac build_aar_module_test
Details
@flutter-dashboard
Mac build_ios_framework_module_test
Details
@flutter-dashboard
Mac build_tests_1_4
Details
@flutter-dashboard
Mac build_tests_2_4
Details
@flutter-dashboard
Mac build_tests_3_4
Details
@flutter-dashboard
Mac build_tests_4_4
Details
@flutter-dashboard
Mac customer_testing
Details
@flutter-dashboard
Mac dart_plugin_registry_test
Details
@flutter-dashboard
Mac framework_tests_libraries
Details
@flutter-dashboard
Mac framework_tests_misc
Details
@flutter-dashboard
Mac framework_tests_widgets
Details
@flutter-dashboard
Mac module_custom_host_app_name_test
Details
@flutter-dashboard
Mac module_host_with_custom_build_test
Details
@flutter-dashboard
Mac module_test
Details
@flutter-dashboard
Mac module_test_ios
Details
@flutter-dashboard
Mac plugin_test
Details
@flutter-dashboard
Mac tool_integration_tests_1_4
Details
@flutter-dashboard
Mac tool_integration_tests_2_4
Details
@flutter-dashboard
Mac tool_integration_tests_3_4
Details
@flutter-dashboard
Mac tool_integration_tests_4_4
Details
@flutter-dashboard
Mac tool_tests_general
Details
@flutter-dashboard
Mac web_tool_tests
Details
@wip
WIP Ready for review
Details
@flutter-dashboard
Windows build_aar_module_test
Details
@flutter-dashboard
Windows build_tests_1_3
Details
@flutter-dashboard
Windows build_tests_2_3
Details
@flutter-dashboard
Windows build_tests_3_3
Details
@flutter-dashboard
Windows customer_testing
Details
@flutter-dashboard
Windows framework_tests_libraries
Details
@flutter-dashboard
Windows framework_tests_misc
Details
@flutter-dashboard
Windows framework_tests_widgets
Details
@flutter-dashboard
Windows module_custom_host_app_name_test
Details
@flutter-dashboard
Windows module_host_with_custom_build_test
Details
@flutter-dashboard
Windows module_test
Details
@flutter-dashboard
Windows plugin_test
Details
@flutter-dashboard
Windows tool_integration_tests_1_5
Details
@flutter-dashboard
Windows tool_integration_tests_2_5
Details
@flutter-dashboard
Windows tool_integration_tests_3_5
Details
@flutter-dashboard
Windows tool_integration_tests_4_5
Details
@flutter-dashboard
Windows tool_integration_tests_5_5
Details
@flutter-dashboard
Windows tool_tests_commands
Details
@flutter-dashboard
Windows tool_tests_general
Details
@flutter-dashboard
Windows web_tool_tests
Details
@cirrus-ci
analyze-linux Task Summary
Details
@flutter-dashboard
ci.yaml validation .ci.yaml validation
Details
@google-cla
cla/google All necessary CLAs are signed
@cirrus-ci
customer_testing-linux Task Summary
Details
@cirrus-ci
docs-linux Task Summary
Details
@flutter-dashboard
flutter-gold All golden file tests have passed.
Details
@cirrus-ci
framework_tests-libraries-linux Task Summary
Details
@cirrus-ci
framework_tests-misc-linux Task Summary
Details
@cirrus-ci
framework_tests-widgets-linux Task Summary
Details
@flutter-dashboard
luci-flutter
Details
@cirrus-ci
tool_tests-commands-linux Task Summary
Details
@cirrus-ci
tool_tests-general-linux Task Summary
Details
@cirrus-ci
web_smoke_test Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants