Looks like soldity-upgrade has input file processing logic duplicated from CommandLineInterface.cpp. Especially readInputFiles() and file reader callback in SourceUpgrade.cpp. This logic in CommandLineInterface has recently been refactored in PRs like #11113, #11518. After #11545/#11617 will actually become functionally different so solidity-upgrade will be unable to resolve imports exactly the same way solc does so projects that depend on --base-path being set properly might no longer compile.
Logic needs to be unified in both places. Both should use FileReader and its callback. Preferably the input processing inside readInputFiles() itself should be shared between the two executables. I think that solidity-upgrade also needs --base-path option.
The text was updated successfully, but these errors were encountered:
We are unable to convert the task to an issue at this time. Please try again.
The issue was successfully created but we are unable to update the comment at this time.
Looks like
soldity-upgradehas input file processing logic duplicated fromCommandLineInterface.cpp. EspeciallyreadInputFiles()and file reader callback inSourceUpgrade.cpp. This logic inCommandLineInterfacehas recently been refactored in PRs like #11113, #11518. After #11545/#11617 will actually become functionally different sosolidity-upgradewill be unable to resolve imports exactly the same waysolcdoes so projects that depend on--base-pathbeing set properly might no longer compile.Logic needs to be unified in both places. Both should use
FileReaderand its callback. Preferably the input processing insidereadInputFiles()itself should be shared between the two executables. I think thatsolidity-upgradealso needs--base-pathoption.The text was updated successfully, but these errors were encountered: