Sitelet https://web.archive.org/web/20210729013208/https://github.com/facebook/jest/issues/10013
Skip to content

/ jest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ProjectConfig.name to ProjectConfig.id #10013

Open
SimenB opened this issue May 10, 2020 · 20 comments · May be fixed by #10051, #10592 or #11089
Open

Rename ProjectConfig.name to ProjectConfig.id #10013

SimenB opened this issue May 10, 2020 · 20 comments · May be fixed by #10051, #10592 or #11089
Labels
Help Wanted good first issue 💣 Breaking change
Milestone
High priority future

Comments

@SimenB
Copy link
Collaborator

@SimenB SimenB commented May 10, 2020

jest/packages/jest-types/src/Config.ts

Line 149 in 0e0eeed

name: string;

jest/packages/jest-config/src/normalize.ts

Lines 364 to 371 in 0e0eeed

if (!options.name) {
options.name = createHash('md5')
.update(options.rootDir)
// In case we load config from some path that has the same root dir
.update(configPath || '')
.update(String(projectIndex))
.digest('hex');
}

This isn't actually a name, it's used as an ID. We have displayName which should be used for e.g. selecting which project to run
@SimenB SimenB added this to the Jest 27 milestone May 10, 2020
@Devanshu24
Copy link

@Devanshu24 Devanshu24 commented May 10, 2020

Could I take this up?
And just to be sure I understand it correctly the task is just to rename the name attribute to id ?
@SimenB
Copy link
Collaborator Author

@SimenB SimenB commented May 10, 2020

Yeah, go for it! And yes, just renaming it 👍 It's used as a key here and there, but TypeScript should tell you where 🙂
@Devanshu24
Copy link

@Devanshu24 Devanshu24 commented May 10, 2020

Great! I'll get right on it!
@msurekci
Copy link

@msurekci msurekci commented May 15, 2020

Hi, can I give this a shot if you have not yet started @Devanshu24 ?
@msurekci msurekci linked a pull request that will close this issue May 15, 2020
Open
@Devanshu24
Copy link

@Devanshu24 Devanshu24 commented May 16, 2020 •
edited

Hey @msurekci! Sorry for not replying fast, I just wasn't able to find all the instances of id in the codebase, so ended up taking quite a bit of time.
Hope you could do it :D
@gautamsingal
Copy link

@gautamsingal gautamsingal commented Jun 12, 2020

@msurekci Is this issue fixed or are you working on it? I would like to pick it up.
@GabeNedden
Copy link

@GabeNedden GabeNedden commented Jun 29, 2020

Hi, first-timer here. I'd love to give this a try
@Thusal06 Thusal06 mentioned this issue Jul 2, 2020
Closed
@Thusal06 Thusal06 mentioned this issue Jul 2, 2020
Closed
@jhalak27
Copy link

@jhalak27 jhalak27 commented Aug 2, 2020

@SimenB Hey, I am new here. Can I work on this?
@jeysal
Copy link
Collaborator

@jeysal jeysal commented Sep 28, 2020

Yes, this appears to be up for grabs
@flozender
Copy link
Contributor

@flozender flozender commented Oct 1, 2020

Hi, may I take this up?
@jhalak27
Copy link

@jhalak27 jhalak27 commented Oct 1, 2020

@jeysal Should I start working on this?
@jeysal
Copy link
Collaborator

@jeysal jeysal commented Oct 1, 2020

@jhalak27 sure, have a go
@jhalak27
Copy link

@jhalak27 jhalak27 commented Oct 5, 2020

Are there the only two files where changes are needed?
Also, just have to change name to id right?
@jeysal
Copy link
Collaborator

@jeysal jeysal commented Oct 5, 2020

Haven't checked how many relevant files there are, but yeah just the name change
@jhalak27 jhalak27 linked a pull request that will close this issue Oct 5, 2020
Open
@jhalak27
Copy link

@jhalak27 jhalak27 commented Oct 5, 2020

@jeysal I have made the changes on relevant files. The Running TypeScript compiler & ESLint is successfully but the other tests are falling as there are corresponding changes required to be done in test files. What should I do?
@joaopedrodcf joaopedrodcf linked a pull request that will close this issue Feb 16, 2021
Open
@joaopedrodcf
Copy link

@joaopedrodcf joaopedrodcf commented Feb 17, 2021

Hey, guys noticed that this is one of the milestones for the jest 27 and also a good first issue because it was stalled since October the last try to fix this I created a new MR to fix this issue. 👋
@GabeNedden
Copy link

@GabeNedden GabeNedden commented Apr 23, 2021

I'm about to get started on this task, just ran a build/ test as a baseline before I start making changes. 52 tests failed, did I do something wrong or is this a normal starting point? Thank you
@joaopedrodcf
Copy link

@joaopedrodcf joaopedrodcf commented Apr 23, 2021

I started this task on here: #11089 but did not get a reply from any of the maintainers. About the unit tests it was difficult to me to make it work I don't know what I did after, while I couldn't I used the pipeline to try to validate everything was working 🤔
@GabeNedden
Copy link

@GabeNedden GabeNedden commented Apr 23, 2021

This is my first time trying to contribute to something. Just making sure I understand, have you already submitted a solution to this issue? If so I think I will try finding something else to work on :)
@joaopedrodcf
Copy link

@joaopedrodcf joaopedrodcf commented Apr 23, 2021

It's also my first time trying to contribute to something as big as jest.
I tried to get a reply from the maintainers from them to validate but until now didn't get any answer.
What took me more time was really the problem with the unit tests.
@jeysal jeysal removed this from the Jest 27 milestone May 20, 2021
@jeysal jeysal added this to the High priority future milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted good first issue 💣 Breaking change
Projects
None yet
Milestone
High priority future
Linked pull requests

Successfully merging a pull request may close this issue.

Rename ProjectConfig.name to ProjectConfig.id
ProjectConfig.name to ProjectConfig.id
feat: Change project config from name to id
9 participants
@SimenB @msurekci @GabeNedden @joaopedrodcf @jeysal @gautamsingal @flozender @jhalak27 @Devanshu24