Sitelet https://web.archive.org/web/20260601131328/https://github.com/pyrogram/pyrogram/pull/706
Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

Removed create_task#706

Merged
delivrance merged 1 commit into
pyrogram:masterfrom
Mahesh0253:patch-1
Apr 15, 2022
Merged

Removed create_task#706
delivrance merged 1 commit into
pyrogram:masterfrom
Mahesh0253:patch-1

Conversation

@Mahesh0253
Copy link
Copy Markdown
Contributor

No need to use loop.create_task in workers, because we awaiting immediately

@delivrance
Copy link
Copy Markdown
Member

Ok, the actual reason is that create_task placed there was spawning extra tasks and thus not staying within the pool and workers count limit of the method.

@delivrance delivrance merged commit 1c22577 into pyrogram:master Apr 15, 2022
AsmSafone pushed a commit to AsmSafone/pyrogram that referenced this pull request Apr 18, 2022
Improve type hinting for join_chat method (pyrogram#957)

Fix inline query results typing (pyrogram#958)

Removed unnecessary create_task (pyrogram#706)

Add bound method Chat.unpin_all_messages (pyrogram#959)

Revert "Remove unneeded parts"

This reverts commit 849321e.

Reformat code

Improve interoperability with threads
AsmSafone pushed a commit to AsmSafone/pyrogram that referenced this pull request Jul 14, 2022
Improve type hinting for join_chat method (pyrogram#957)

Fix inline query results typing (pyrogram#958)

Removed unnecessary create_task (pyrogram#706)

Add bound method Chat.unpin_all_messages (pyrogram#959)

Revert "Remove unneeded parts"

This reverts commit 849321e.

Reformat code

Improve interoperability with threads

add support for new pyro strings

Revert "add support for new pyro strings"

This reverts commit 0ef1bcf.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants