Fix ref to protocol class in code example#27014
Closed
akulakov wants to merge 1 commit into
Closed
Conversation
Member
|
Hm, the original looks right to me. The point of the example is that C conforms to Proto, IIUC. @Fidget-Spinner |
Contributor
Author
|
@gvanrossum Sorry about that, I've misunderstood the example.. closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In code example for typing.Protocol, reference to the previous example is used, instead it should reference the
Cclass used in current example. As it is now, it's confusing and code sample is not runnable.