Sitelet https://web.archive.org/web/20210628182156/https://github.com/angular/angular-cli/pull/21189
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): add support to inline Adobe Fonts #21189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jun 24, 2021

With this change we add support to inline external Adobe fonts into the index html, we also add a preconnect hint which helps improve page load speed.

Closes #21186

@alan-agius4 alan-agius4 requested review from mgechev and clydin Jun 24, 2021
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@alan-agius4 alan-agius4 force-pushed the alan-agius4:adobe-typekit branch from 89df8ec to efa5962 Jun 24, 2021
@alan-agius4 alan-agius4 reopened this Jun 24, 2021
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Jun 24, 2021
In version 12.1, we includined font inlining for Adobe font, see: angular/angular-cli#21189
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Jun 24, 2021
In version 12.1, we included font inlining for Adobe fonts, see: angular/angular-cli#21189
@alan-agius4 alan-agius4 force-pushed the alan-agius4:adobe-typekit branch from 85b394d to 4f14204 Jun 24, 2021
With this change we add support to inline external Adobe fonts into the index html, we also add a `preconnect` hint which helps improve page load speed.

Closes #21186
@alan-agius4 alan-agius4 force-pushed the alan-agius4:adobe-typekit branch from 4f14204 to 3e08348 Jun 24, 2021
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Jun 25, 2021
In version 12.1, we included font inlining for Adobe fonts, see: angular/angular-cli#21189
@clydin
clydin approved these changes Jun 28, 2021
Copy link
Member

@mgechev mgechev left a comment

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants