Java: Preserve taint on field-read-steps on entrypoint types #6098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
reviewed
Jun 25, 2021
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Jun 25, 2021
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Jun 29, 2021
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Jun 29, 2021
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Jun 29, 2021
java/ql/test/library-tests/dataflow/entrypoint-types/EntryPointTypesTest.java
Show resolved
Hide resolved
aschackmull
reviewed
Jun 30, 2021
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Aug 4, 2021
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
Aug 4, 2021
Contributor
aschackmull
left a comment
There was a problem hiding this comment.
This looks reasonable, but adds quite a number of new steps, so we should check for performance impact.
a58d4cc to
217d14f
Compare
Contributor
Author
|
Force-pushed to fix conflicts. @aschackmull did the performance evaluation work out? |
Contributor
|
Looks like we need a rebase to enable a dca run. |
aschackmull
reviewed
Dec 7, 2021
java/ql/lib/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Outdated
Show resolved
Hide resolved
3c45d9f to
27f4554
Compare
…il.qll Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
27f4554 to
c1e4c05
Compare
Contributor
Author
|
DCA experiment looks good. I force-pushed to adapt the change note to the new format. |
aschackmull
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional taint step between remote source
Parametertypes (e.g. parameters of aJAX-RSresource method) and field reads on said types (either directly or through getters).Credits to @pwntester for the solution proposal.