Sitelet https://web.archive.org/web/20250701035953/https://github.com/python/cpython/pull/26417
Skip to content

bpo-44257: Fix typo and change to more compact grammar #26417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-44257: Fix typo and change to more compact grammar #26417

wants to merge 1 commit into from

Conversation

ShinWonho
Copy link

@ShinWonho ShinWonho commented May 28, 2021 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ShinWonho

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

lysnikolaou
lysnikolaou requested changes May 28, 2021
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShinWonho and congrats on your first PR!

Your refactorings of the star_expressions and expressions rules are wrong. Notice how the alternatives have different actions, so that if we have only one expression, that gets returned by itself, without being wrapped in a tuple. So leave those be for now.

If you want, you can remove those changes and I'd be happy to merge this to fix the typo in assignment_expression.

Also, please take care of the CLA by following @the-knights-who-say-ni's instructions.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ShinWonho ShinWonho requested a review from lysnikolaou June 1, 2021 07:22
@ShinWonho ShinWonho marked this pull request as draft June 1, 2021 07:22
@ShinWonho
Copy link
Author

Thanks for the response!
However, I mistakenly clicked the requested a review button.
Sorry for the confuse.
I'll check again and update it (also take care of CLA)

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 2, 2021
@pablogsal pablogsal closed this Nov 3, 2021
@pablogsal
Copy link
Member

I'm closing this for the time being. Please, feel free to reopen a new PR if you wish to continue the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
awaiting changes stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShinWonho @the-knights-who-say-ni @bedevere-bot @pablogsal @lysnikolaou