Sitelet https://web.archive.org/web/20210829060231/https://github.com/nodejs/node/pull/38895
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: correct Xcode spelling in .gitignore #38895

Closed
wants to merge 1 commit into from
Closed

build: correct Xcode spelling in .gitignore #38895

wants to merge 1 commit into from

Conversation

@bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jun 1, 2021

No description provided.

@github-actions github-actions bot added the meta label Jun 1, 2021
@targos
targos approved these changes Jun 1, 2021
@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Jun 1, 2021

GHA added the meta label — @targos would it be better if I changed the subsystem in the commit message / PR title to meta?

@cjihrig
cjihrig approved these changes Jun 2, 2021
@Trott
Trott approved these changes Jun 2, 2021
@didacta
didacta approved these changes Jun 4, 2021
@Lxxyx
Lxxyx approved these changes Jun 5, 2021
@jasnell
jasnell approved these changes Jun 7, 2021
@jasnell
Copy link
Member

@jasnell jasnell commented Jun 7, 2021

Landed in 7727dd5

@jasnell jasnell closed this Jun 7, 2021
jasnell added a commit that referenced this pull request Jun 7, 2021
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bl-ue bl-ue deleted the bl-ue:xcode-spelling branch Jun 7, 2021
targos added a commit that referenced this pull request Jun 11, 2021
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
richardlau added a commit that referenced this pull request Jul 16, 2021
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau added a commit that referenced this pull request Jul 19, 2021
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau added a commit that referenced this pull request Jul 20, 2021
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants