fix(@angular-devkit/build-angular): display the code-frame for localization errors#19982
fix(@angular-devkit/build-angular): display the code-frame for localization errors#19982petebacondarwin wants to merge 1 commit intoangular:masterfrom
Conversation
|
Probably easiest to review the changes with whitespace matching turned off. |
|
@petebacondarwin, going through some old PRs, is this still something you want to land, or should we close this? |
|
I totally forgot about this. I see it is conflicted and I set it to WIP - perhaps because of the Windows failures... |
…zation errors Previously if there was an error processing the AST in the Babel plugin that does the replacement of i18n messages, the error shown did not provide much help in where in the code the problem appears. Now we display a "code-frame" representation of the position in the parsed source-code where the AST processing failed. Partially resolves angular/angular#40702 (comment)
3be3b35 to
d366461
Compare
|
This is stale and would require a |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Previously if there was an error processing the AST in the Babel plugin that does
the replacement of i18n messages, the error shown did not provide much help
in where in the code the problem appears.
Now we display a "code-frame" representation of the position in the parsed
source-code where the AST processing failed.
Partially resolves angular/angular#40702 (comment)