Sitelet https://web.archive.org/web/20210505215725/https://github.com/arrayfire/arrayfire/pull/3129
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing batch support check in sparse-dense arith ops #3129

Merged
merged 2 commits into from May 5, 2021

Conversation

@9prady9
Copy link
Member

@9prady9 9prady9 commented May 4, 2021

Description

Fixes: #1988

Changes to Users

Prior to this change, sparse-dense arithmetic API calls incorrectly continued with the operation where batch support was in fact not yet available. Until such support is added later, we need correctly return an appropriate error code.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented
@9prady9 9prady9 added the fix label May 4, 2021
@9prady9 9prady9 added this to the 3.8.1 milestone May 4, 2021
@9prady9 9prady9 requested a review from umar456 May 4, 2021
@umar456
umar456 approved these changes May 5, 2021
@9prady9 9prady9 merged commit ecce064 into arrayfire:master May 5, 2021
21 of 24 checks passed
21 of 24 checks passed
@github-actions
CPU (Atlas, ubuntu-18.04)
Details
@github-actions
CPU (OpenBLAS, windows-latest)
Details
@github-actions
Clang Format Lint
Details
@github-actions
Documentation
Details
@github-actions
CPU (MKL, ubuntu-16.04)
Details
@github-actions
CPU (MKL, ubuntu-18.04)
Details
@github-actions
CPU (OpenBLAS, ubuntu-16.04)
Details
@github-actions
CPU (OpenBLAS, ubuntu-18.04)
Details
@github-actions
CPU (OpenBLAS, macos-latest)
Details
@arrayfire-ci
ci/linux-all Build done.
Details
@arrayfire-ci
ci/ubuntu-cuda-p100 Build done.
Details
@arrayfire-ci
ci/ubuntu1804-cuda-11-1-cuda-a100 Build done.
Details
@arrayfire-ci
ci/ubuntu-cpu-e2620v4 Build done.
Details
@arrayfire-ci
ci/ubuntu-cpu-e2620v4-asan Build done.
Details
@arrayfire-ci
ci/ubuntu-cuda-k80 Build done.
Details
@arrayfire-ci
ci/ubuntu-cuda-v100 Build done.
Details
@arrayfire-ci
ci/ubuntu-cuda-v100-asan Build done.
Details
@arrayfire-ci
ci/ubuntu-opencl-k80 Build done.
Details
@arrayfire-ci
ci/ubuntu-opencl-k80-asan Build done.
Details
@arrayfire-ci
ci/ubuntu-opencl-p100 Build done.
Details
@arrayfire-ci
ci/ubuntu-opencl-v100 Build done.
Details
@arrayfire-ci
ci/ubuntu1804-cuda-11-1-cuda-t4 Build done.
Details
@arrayfire-ci
ci/ubuntu1804-cuda-11-1-opencl-a100 Build done.
Details
@arrayfire-ci
ci/ubuntu1804-cuda-11-1-opencl-t4 Build done.
Details
@9prady9 9prady9 deleted the 9prady9:fix_sparse_matmul_check branch May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants