Sitelet https://web.archive.org/web/20201106202147/https://github.com/python-gitlab/python-gitlab/pull/1115
Skip to content

/ python-gitlab

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/keyset pagination revert #1115

Merged
merged 2 commits into from Jun 9, 2020
Merged

Fix/keyset pagination revert #1115

merged 2 commits into from Jun 9, 2020

Conversation

@max-wittig
Copy link
Member

@max-wittig max-wittig commented Jun 9, 2020

/cc @nejch
@max-wittig max-wittig force-pushed the fix/keyset-pagination-revert branch from 70db3c6 to b20c307 Jun 9, 2020
max-wittig added 2 commits Jun 9, 2020
@max-wittig
fix: disable default keyset pagination
e71fe16 
Instead we set pagination to offset on the other paths
@max-wittig
chore: bump version to 2.3.1
Loading status checks…
870e7ea
@max-wittig max-wittig force-pushed the fix/keyset-pagination-revert branch from b20c307 to 870e7ea Jun 9, 2020
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 9, 2020 •
edited

Codecov Report

Merging #1115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1115   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files          10       10           
  Lines        2759     2759           
=======================================
  Hits         2125     2125           
  Misses        634      634

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7dbc8...870e7ea. Read the comment docs.
@bufferoverflow
bufferoverflow approved these changes Jun 9, 2020
View changes
@bufferoverflow bufferoverflow merged commit 3f585ad into master Jun 9, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bufferoverflow bufferoverflow deleted the fix/keyset-pagination-revert branch Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferoverflow bufferoverflow

Assignees

@bufferoverflow bufferoverflow

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@max-wittig @codecov-commenter @bufferoverflow
You can’t perform that action at this time.