Sitelet https://web.archive.org/web/20201106202135/https://github.com/python-gitlab/python-gitlab/pull/1145
Skip to content

/ python-gitlab

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pagination to be set in config globally and via cli #1145

Open
wants to merge 1 commit into
base: master
from
Open

Allow pagination to be set in config globally and via cli #1145

wants to merge 1 commit into from

Conversation

@ericfrederich
Copy link
Contributor

@ericfrederich ericfrederich commented Aug 7, 2020

Also allow order_by to be set in globally in config
@ericfrederich ericfrederich force-pushed the ericfrederich:fix-1144 branch 2 times, most recently from 1920ec6 to 4a73d04 Aug 7, 2020
@ericfrederich
feat: allow pagination to be set in config globally and via cli
Unverified
This user has not uploaded their public key yet.
GPG key ID: 9F2136932FBB7EAC Learn about signing commits
Loading status checks…
1453208 
Also allow order_by to be set in globally in config
Fixes #1144
@ericfrederich ericfrederich force-pushed the ericfrederich:fix-1144 branch from 4a73d04 to 1453208 Aug 7, 2020
@max-wittig
Copy link
Member

@max-wittig max-wittig commented Aug 17, 2020

Thanks for the MR! We had a similar change before. If pagination is set to keyset and you e.g. request merge requests, then GitLab will just throw 400 at you, so we would need a allow-list for this case to only use keyset, if the endpoint supports it.
@max-wittig
Copy link
Member

@max-wittig max-wittig commented Aug 31, 2020

@ericfrederich See here: https://github.com/python-gitlab/python-gitlab/pull/1110/files

The problem with keyset pagination is that it breaks the workflow of some people, because GitLab will not send out pagination headers in this pagination mode. I've tried to re-add these upstream (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/34273), but GitLab doesn't seem to want that ☹️
@max-wittig
Copy link
Member

@max-wittig max-wittig commented Aug 31, 2020

@ericfrederich Any ideas how to continue here without breaking peoples workflow?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ericfrederich ericfrederich

Labels
Waiting for response
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ericfrederich @max-wittig
You can’t perform that action at this time.