Sitelet https://web.archive.org/web/20210323191558/https://github.com/papercups-io/papercups/issues/571
Skip to content

/ papercups

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic text search through tags #571

Open
cheeseblubber opened this issue Feb 10, 2021 · 3 comments
Open

Basic text search through tags #571

cheeseblubber opened this issue Feb 10, 2021 · 3 comments
Assignees
@imjared
Labels
enhancement frontend good first issue
Projects
Managing customer feedback

Comments

@cheeseblubber
Copy link
Contributor

@cheeseblubber cheeseblubber commented Feb 10, 2021

I want to be able to do basic string text search through tags of descriptions and tags on tags page
@cheeseblubber cheeseblubber added the enhancement label Feb 10, 2021
@cheeseblubber cheeseblubber added this to To do in Managing customer feedback Feb 10, 2021
@reichert621 reichert621 added frontend good first issue labels Mar 9, 2021
@imjared
Copy link

@imjared imjared commented Mar 22, 2021

i'd be down to take a pass at this. would you expect all searching to be done on the client against a list of fetched tags?
@reichert621
Copy link
Collaborator

@reichert621 reichert621 commented Mar 22, 2021

@imjared yup let's just do a client side search for now :)

maybe just put a search input above the tags table (in the TagsOverview.tsx) here:
Screen Shot 2021-03-22 at 10 22 11 AM
@reichert621 reichert621 assigned imjared Mar 22, 2021
@reichert621
Copy link
Collaborator

@reichert621 reichert621 commented Mar 22, 2021

@imjared I added this on the customers overview today if you want to take a look for reference :) https://github.com/papercups-io/papercups/blob/master/assets/src/components/customers/CustomersPage.tsx#L158-L165

Screen Shot 2021-03-22 at 6 57 54 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imjared imjared

Labels
enhancement frontend good first issue
Projects
Managing customer feedback
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@imjared @cheeseblubber @reichert621