JS: cache more predicates #5382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'd feel a lot more confident about this if we had a way to measure cache size 😓 . |
Contributor
Why don't we just do that with |
Contributor
Author
Is that something you're planning on? Because I think that sounds like a good idea. |
Contributor
Author
|
The cache size grows from 17% of the DB size to 19% of the DB size according to Esbens evaluation. So no dramatic increase in cache size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at which predicates are often used in the last stage, and then I
cachedsome of them.An evaluation shows ~4% improvement on the security suite.