Sitelet https://web.archive.org/web/20210707140903/https://github.com/angular/angular/issues/41117
Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Remove the code added in #41106 to reduce bundle size #41117

Open
gkalpak opened this issue Mar 8, 2021 · 4 comments
Open

[docs-infra] Remove the code added in #41106 to reduce bundle size #41117

gkalpak opened this issue Mar 8, 2021 · 4 comments
Labels
P3 comp: docs-infra
Projects
docs-infra
Milestone
Backlog

Comments

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 8, 2021

This issue is tracking removing the code temporarily added in #41106 (to help with debudding a ServiceWorker issue) in order to reclaim the extra bundle size.
@gkalpak gkalpak mentioned this issue Mar 8, 2021
Closed
@gkalpak gkalpak added this to the docs-infra-aio-app milestone Mar 8, 2021
@ngbot ngbot bot removed this from the docs-infra-aio-app milestone Mar 8, 2021
@gkalpak gkalpak added this to SELECTED FOR DEVELOPMENT in docs-infra Mar 8, 2021
@ngbot ngbot bot added this to the needsTriage milestone Mar 8, 2021
@jelbourn jelbourn added the P3 label Mar 8, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 8, 2021
@gkalpak
Copy link
Member Author

@gkalpak gkalpak commented Apr 20, 2021 •
edited

For reference, I ran into this the other day and captured the following log: SW-error-log.txt
(Now, I need to find some time and analyze 😁)

UPDATE:
I looked at the logs and I am still none the wiser 😁
The bundles that failed to be fetched are reported as being present in the cache, so I have no idea what might be going on 😕
@JoostK
Copy link
Member

@JoostK JoostK commented May 7, 2021

Sharing this here but it looks like it's the same situation as George analyzed above: the chunk is said to be present in the cache.

Logging 
Failed to load resource: the server responded with a status of 404 ()
main-es2015.5bdd22efd2bd48dd1d9e.js:1 ERROR Error: [DocViewer] Error preparing document 'guide/router-tutorial-toh': ChunkLoadError: Loading chunk 1 failed.
(error: https://angular.io/default~code-code-example-module~code-code-tabs-module-es2015.48e4e1c9f1670b9cec23.js)
    at Function.c.e (runtime-es2015.079cdaf7df823193c268.js:1)
    at loadChildren (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at t.loadCustomElement (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at main-es2015.5bdd22efd2bd48dd1d9e.js:1
    at Array.map (<anonymous>)
    at t.loadContainedCustomElements (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at u.project (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at u._next (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at u.next (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c._next (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c.selector (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c.error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c._error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c.error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at u._error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at u.error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c._error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at c.error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at u.notifyError (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
    at r._error (main-es2015.5bdd22efd2bd48dd1d9e.js:1)
vs @ main-es2015.5bdd22efd2bd48dd1d9e.js:1
main-es2015.5bdd22efd2bd48dd1d9e.js:1 
ServiceWorker: activated
main-es2015.5bdd22efd2bd48dd1d9e.js:1 
Cache: ngsw:/:db:control (2 entries)
  - https://angular.io/assignments: {}
  - https://angular.io/latest: {"latest":"647b919ada8975b9f101090f79c9db9f1e900240"}
main-es2015.5bdd22efd2bd48dd1d9e.js:1 
Cache: ngsw:/:647b919ada8975b9f101090f79c9db9f1e900240:assets:app-shell:cache (26 entries)
  - https://angular.io/toc-toc-module-es2015.d1fa63cbc4f8ec0088ea.js
  - https://angular.io/default~code-code-example-module~code-code-tabs-module-es2015.48e4e1c9f1670b9cec23.js
  - https://angular.io/code-code-example-module-es2015.af6b398dde18d5f1d877.js
  - https://angular.io/assets-js-prettify-js-es2015.b6cbad02a0e3ac8af12a.js
  - https://fonts.gstatic.com/s/robotomono/v13/L0x5DF4xlVMF-BfR8bXMIjhLq3-cXbKD.woff2
  - https://angular.io/0-es2015.1bf0c2776281d14071b6.worker.js
  - https://angular.io/announcement-bar-announcement-bar-module-es2015.1b5b762c9c8837c770f8.js
  - https://angular.io/api-api-list-module-es2015.40a43cd22f50f64d63bb.js
  - https://angular.io/assets/images/favicons/favicon.ico
  - https://angular.io/assets/js/prettify.js
  - https://angular.io/code-code-tabs-module-es2015.1a6c55229832dae43d3d.js
  - https://angular.io/contributor-contributor-list-module-es2015.c8325875e1dc65af0dc6.js
  - https://angular.io/events-events-module-es2015.6447f4bc09fdcfbb5676.js
  - https://angular.io/index.html
  - https://angular.io/live-example-live-example-module-es2015.e26ac21b0f5aff3a4dc7.js
  - https://angular.io/main-es2015.5bdd22efd2bd48dd1d9e.js
  - https://angular.io/polyfills-es2015.1a4c72da9816597260d1.js
  - https://angular.io/pwa-manifest.json
  - https://angular.io/resource-resource-list-module-es2015.c10f93cd4e05eaabbcfd.js
  - https://angular.io/runtime-es2015.079cdaf7df823193c268.js
  - https://angular.io/search-file-not-found-search-module-es2015.5f87faadeb778e77ea33.js
  - https://angular.io/styles.6949abf903d5ee1d9240.css
  - https://fonts.gstatic.com/s/roboto/v27/KFOlCnqEu92Fr1MmEU9fBBc4AMP6lQ.woff2
  - https://fonts.gstatic.com/s/roboto/v27/KFOmCnqEu92Fr1Mu4mxKKTU1Kg.woff2
  - https://fonts.gstatic.com/s/roboto/v27/KFOlCnqEu92Fr1MmSU5fBBc4AMP6lQ.woff2
  - https://fonts.gstatic.com/s/roboto/v27/KFOmCnqEu92Fr1Me5g.woff
main-es2015.5bdd22efd2bd48dd1d9e.js:1 
Cache: ngsw:/:db:ngsw:/:647b919ada8975b9f101090f79c9db9f1e900240:assets:app-shell:meta (5 entries)
  - https://angular.io/https://fonts.gstatic.com/s/robotomono/v13/L0x5DF4xlVMF-BfR8bXMIjhLq3-cXbKD.woff2: {"ts":1619613834307,"used":true}
  - https://angular.io/https://fonts.gstatic.com/s/roboto/v27/KFOlCnqEu92Fr1MmEU9fBBc4AMP6lQ.woff2: {"ts":1620376937064,"used":true}
  - https://angular.io/https://fonts.gstatic.com/s/roboto/v27/KFOmCnqEu92Fr1Mu4mxKKTU1Kg.woff2: {"ts":1620376937093,"used":true}
  - https://angular.io/https://fonts.gstatic.com/s/roboto/v27/KFOlCnqEu92Fr1MmSU5fBBc4AMP6lQ.woff2: {"ts":1620376937109,"used":true}
  - https://angular.io/https://fonts.gstatic.com/s/roboto/v27/KFOmCnqEu92Fr1Me5g.woff: {"ts":1620376937202,"used":true}
@gkalpak
Copy link
Member Author

@gkalpak gkalpak commented May 11, 2021

Another occurrence: #28114 (comment)
@gkalpak gkalpak mentioned this issue May 11, 2021
Open
1 of 3 tasks
@gkalpak gkalpak mentioned this issue May 25, 2021
Closed
@gkalpak
Copy link
Member Author

@gkalpak gkalpak commented Jun 19, 2021

FYI, I have looked at the data and haven't been able to figure out what is going on.

However, I did find out that we didn't get the client ID for navigation requests, so I created #42607. (The likelihood of this being the cause of the issue is quite small (unless I am missing something), but let's see if it helps.)
gkalpak added a commit to gkalpak/angular that referenced this issue Jul 7, 2021
@gkalpak
fix(docs-infra): log more SW debug info
52c54ce 
This commit expands the info printed to the console to help diagnose
ServiceWorker issues to include the [internal debug info][1] retrieved
from `/ngsw/state`. This will provide more useful data, such as the
activated SW's version, state, clients, recent operations and any recent
errors.

NOTE:
This temporarily increases the payload size. Removing this code and
reclaiming the payload size is being tracked in angular#41117.

[1]: https://angular.io/guide/service-worker-devops#locating-and-analyzing-debugging-information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 comp: docs-infra
Projects
docs-infra
SELECTED FOR DEVELOPMENT
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@JoostK @jelbourn @gkalpak @AndrewKushnir