Sitelet https://web.archive.org/web/20210219062941/https://github.com/angular/components/pull/21080
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest @angular/dev-infra-private and husky@5 #21080

Merged
merged 3 commits into from Jan 12, 2021

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Nov 18, 2020

See individual commits.

@josephperrott josephperrott requested a review from angular/dev-infra-components as a code owner Nov 18, 2020
@google-cla google-cla bot added the cla: yes label Nov 18, 2020
Copy link
Member

@crisbeto crisbeto left a comment

LGTM, but the lint check appears to be failing.

@@ -0,0 +1 @@
_

This comment has been minimized.

@crisbeto

crisbeto Nov 23, 2020
Member

Do we need this .gitignore or can we put this value in the global one?

This comment has been minimized.

@josephperrott

josephperrott Dec 1, 2020
Author Member

This is actually created by husky during install. We can remove it from the global one if you would like, though it was put in place so that if you switch between branches that are and are not updated to husky 5, it remains gitignored.

@josephperrott josephperrott force-pushed the josephperrott:update-dev-infra branch from 581e64c to b12d7cc Dec 1, 2020
@josephperrott josephperrott requested a review from jelbourn as a code owner Dec 1, 2020
.husky/commit-msg Show resolved Hide resolved
Update to the latest version of @angular/dev-infra-private
Update to latest version of husky, which better supports windows
@josephperrott josephperrott added merge ready and removed blocked labels Jan 11, 2021
@josephperrott josephperrott force-pushed the josephperrott:update-dev-infra branch from b12d7cc to 7618bdf Jan 11, 2021
@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jan 12, 2021

bumping to minor since there are conflicts with patch branch

@mmalerba mmalerba merged commit 87baaeb into angular:master Jan 12, 2021
16 checks passed
16 checks passed
Inclusive Language Check completed with success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: upload_release_packages Your tests passed on CircleCI!
Details
ci/circleci: view_engine_build Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 12, 2021
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 12, 2021
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 12, 2021
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 12, 2021
mmalerba pushed a commit that referenced this pull request Jan 13, 2021
This is the patch only change for #21080
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
* build: update dev-infra-private version

Update to the latest version of @angular/dev-infra-private

* fixup! build: update dev-infra-private version

* build: update to husky@5

Update to latest version of husky, which better supports windows
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Feb 12, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants