Sitelet https://web.archive.org/web/20210219063907/https://github.com/angular/components/pull/20773
Skip to content

/ components

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix link in DEV_ENVIRONMENT guide #20773

Merged
merged 1 commit into from Dec 14, 2020
Merged

docs: fix link in DEV_ENVIRONMENT guide #20773

merged 1 commit into from Dec 14, 2020

Conversation

@bampakoa
Copy link
Contributor

@bampakoa bampakoa commented Oct 13, 2020

Fix link for installing MSYS2 in the Developer guide
@bampakoa bampakoa requested a review from angular/dev-infra-components as a code owner Oct 13, 2020
@google-cla google-cla bot added the cla: yes label Oct 13, 2020
@bampakoa
Copy link
Contributor Author

@bampakoa bampakoa commented Oct 13, 2020

I am trying to submit this PR but the lint rule of the CI fails because chore is not in the list of available TYPES, although it is included as a valid type in the CONTRIBUTING guide . I would appreciate any help on that 🙏
@crisbeto
crisbeto approved these changes Oct 14, 2020
View changes
Copy link
Member

@crisbeto crisbeto left a comment

The change LGTM. Regarding the lint failure, you could change it to docs, although I'm not completely sure that it won't require a scope.
@josephperrott josephperrott force-pushed the bampakoa:dev-docs branch from 597acb2 to de40b47 Oct 14, 2020
@bampakoa bampakoa force-pushed the bampakoa:dev-docs branch from de40b47 to f4f2a3a Oct 18, 2020
@bampakoa @josephperrott
docs: fix link in DEV_ENVIRONMENT guide
Loading status checks…
440b31f 
Fix link for installing MSYS2 in the Developer guide
@josephperrott josephperrott force-pushed the bampakoa:dev-docs branch from f4f2a3a to 440b31f Nov 12, 2020
@josephperrott josephperrott changed the title chore: Fix link in DEV_ENVIRONMENT guide docs: fix link in DEV_ENVIRONMENT guide Nov 12, 2020
@josephperrott
josephperrott approved these changes Nov 12, 2020
View changes
Copy link
Member

@josephperrott josephperrott left a comment

LGTM
@mmalerba mmalerba merged commit 272c1a3 into angular:master Dec 14, 2020
16 checks passed
16 checks passed
Inclusive Language Check completed with notices
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: upload_release_packages Your tests passed on CircleCI!
Details
ci/circleci: view_engine_build Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
mmalerba added a commit that referenced this pull request Dec 14, 2020
@bampakoa @mmalerba
docs: fix link in DEV_ENVIRONMENT guide (#20773)
Loading status checks…
4af4477 
Fix link for installing MSYS2 in the Developer guide

(cherry picked from commit 272c1a3)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jan 14, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

@josephperrott josephperrott

Assignees
No one assigned
Labels
cla: yes docs merge ready merge safe target: patch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@bampakoa @crisbeto @josephperrott @mmalerba