Have constructing relative Name with length() == MAXNAME fail #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Name() constructor will currently fail if it's length() would end up being longer than MAXNAME (255). However, there is an edge case where a relative name can be exactly MAXNAME long. This is legal but the lookup mechanism will then fail to make the name absolute by appending an empty label to be able to use it for lookups.
|
Kudos, SonarCloud Quality Gate passed! |
ibauersachs
approved these changes
Feb 15, 2021
I hope this doesn't break stuff. But comparing it with ldns, I think it's okay. Although ldns allows creating a 3x63+62 relative name with status OK, it fails to do anything with it later on, including to converting back to string. ldns even violates it's own guarantee that an rdf internally is always absolute in the 3x63+62 case and returns a length of 256.
| String label62 = IntStream.range(0, 62).mapToObj(i -> "a").collect(Collectors.joining()); | ||
| assertThrows( | ||
| TextParseException.class, | ||
| () -> new Name(format("%s.%s.%s.%s", label63, label63, label63, label62))); |
There was a problem hiding this comment.
I'm not used to importing anything statically other than assertions or (sometimes) constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The Name() constructor will currently fail if it's length() would
end up being longer than MAXNAME (255). However, there is an edge
case where a relative name can be exactly MAXNAME long. This is
legal but the lookup mechanism will then fail to make the name
absolute by appending an empty label to be able to use it for
lookups.